Re: psql with "Function Type" in \df

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql with "Function Type" in \df
Date: 2009-04-27 17:11:44
Message-ID: 7246.1240852304@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Fetter <david(at)fetter(dot)org> writes:
> I have a handle on the problem, which is that the tab completion code
> assumes, wrongly, that it only needs to deal with fixed strings. It's
> actually been false for some time in the \div case, for example. The
> S option has shattered the fixed-string assumption.

Check.

> I'm proposing to refactor the backslash handling code so all of it is
> in one spot with differences in the target list and WHERE clauses
> depending on whether it's tab completion, S, +, what I'm thinking of
> as second-level options--the [ivt]* in \d[ivt]* and the [antw]* in
> \df[antw]*[S+]--and patterns.

> Does this sound reasonable?

It seems like rather a large change to be making in beta. Can you make
a small patch that fixes the immediate problem, and leave the
refactoring for 8.5?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2009-04-27 17:18:43 Re: psql with "Function Type" in \df
Previous Message David Fetter 2009-04-27 16:51:46 Re: psql with "Function Type" in \df