Re: WIP patch for consolidating misplaced-aggregate checks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP patch for consolidating misplaced-aggregate checks
Date: 2012-08-09 23:15:26
Message-ID: 7204.1344554126@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's an updated version taking into account the discussion so far.
It's still a net addition of code (about +200 lines according to
diffstat), but I think the consolidation of logic is probably worth
that.

Any further comments?

regards, tom lane

Attachment Content-Type Size
agg-check-refactor-2.patch.gz application/octet-stream 28.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-08-10 00:06:19 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap
Previous Message Jim Nasby 2012-08-09 22:57:51 Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap