Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pg_regress breaks on msys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_regress breaks on msys
Date: 2006-07-28 20:08:24
Message-ID: 717.1154117304@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> Tom Lane wrote:
>>> The cases that I think we most need to defend against are
>>> (A) diff program not found

> In summary, on MinGW, files differ or 'diff' not found, returns 1.  If
> one of the files to be compared does not exist, it returns 2.  And of
> course, if the files are the same, it returns zero.

OK.  The problem here is that pg_regress is coded to assume that
zero-length output file represents success.  Given the above Windows
behavior that is *clearly* not good enough, because that's probably
exactly what we will see after diff-not-found (if the Windows shell
acts like a Unix shell does and creates the ">" target first).

I'd suggest modifying the logic so that zero-length output file with a
nonzero return from the child be treated as a fatal condition (not just
a difference, but bail out).

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Stefan KaltenbrunnerDate: 2006-07-28 20:13:06
Subject: Re: [Pgbuildfarm-members] [Fwd: RE: Build farm on Windows]
Previous:From: Bruce MomjianDate: 2006-07-28 20:04:00
Subject: Re: [HACKERS] pg_regress breaks on msys

pgsql-patches by date

Next:From: Joe ConwayDate: 2006-07-28 20:42:17
Subject: Re: [HACKERS] 8.2 features?
Previous:From: Bruce MomjianDate: 2006-07-28 20:04:00
Subject: Re: [HACKERS] pg_regress breaks on msys

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group