| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Robert Vollmert <rob(at)vllmrt(dot)net>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: inconsistent behaviour of json_to_record and friends with embedded json |
| Date: | 2019-06-11 18:53:58 |
| Message-ID: | 6c07d61e-be88-a2d2-f158-023175b9e03f@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 6/11/19 1:35 PM, Tom Lane wrote:
> I wrote:
>> I agree. It looks to me like the problem is this over-optimistic
>> assumption:
>> /*
>> * Add quotes around string value (should be already escaped) if
>> * converting to json/jsonb.
>> */
>> No, it's *not* already escaped. Fixing the code to use escape_json()
>> is a bit tedious, because for some reason that function wasn't designed
>> to support non-null-terminated input, but with the attached patch we get
>> what seems to me like sane behavior:
> Hearing no comments, I've pushed this patch. I also rewrote the
> documentation to provide something approaching a specification for
> what json_to_record() and friends do.
Sorry, I meant to tell you your fix looked good to me, it slipped
through the net.
Thanks for fixing this.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2019-06-11 19:22:22 | BUG #15846: problem with the pgdg repository for fedora-29 |
| Previous Message | Tom Lane | 2019-06-11 17:35:34 | Re: inconsistent behaviour of json_to_record and friends with embedded json |