Re: Bizarre reindex_relation API

On Apr 16, 2011, at 11:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Why in the world is reindex_relation defined like this?
>
> #define REINDEX_CHECK_CONSTRAINTS 0x1
> #define REINDEX_SUPPRESS_INDEX_USE 0x2
> extern bool reindex_relation(Oid relid, bool toast_too, int flags);
>
> Seems like a rational design would have folded toast_too in as another
> flag bit, instead of keeping it a separate argument.

I thought about that for roughly three minutes, decided there was something awkward about it that I no longer recall, and it go. I don't object if you want to rejigger it.

...Robert