Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance

> >>And the patch that was applied gives the same result.
> >>
> >>What is more, I am not seeing the reported speedup - in fact I am
> >>seeing no speedup worth mentioning.
> >>
> >>This is on XP-Pro, with default postgres settings. The test
> sets were
> >>somewhat larger than thos Magnus used - basically TPC-H
> lineitems and
> >>orders tables (6m and 1.5m rows respectively).
> >>
> >>
> >
> >First, that was Merlin and not me :-)
> >
> >
>
> My apologies to both of you. Or to at least one of you, anyway. :-)

:-)

> >Second, it didn't really show any improvement for him either in his
> >normal test. But when he re-ran it with just the count(*) test it
> >showed improvement. Did you run a count(*) test or some other test?
>
>
> The tests were
<snip>

That certainly looks like a similar test. Just checking :-)

You were on XP - Merlin, what OS were you on? It could be possible
things have chenged there as well...

> But it looks to me like we need to leave this for 8.2 now
> anyway, unless someone can quickly get to the bottom of why
> it's hanging.

Agreed. I definitly vote for backing out the patch so we don't block the
release. If we find the problem we put it back in before release, but if
it takes a while we just wait for 8.2.

//Magnus