| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Cc: | "Hiroshi Saito" <saito(at)inetrt(dot)skcapi(dot)co(dot)jp> |
| Subject: | Re: CVS of 8.1.x MS-VC6 probrem. |
| Date: | 2005-12-09 11:33:27 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE6C7D2A@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> While I have applied your patch, I am now confused about
> something. Your change was to pg_config.h.win32, which is
> used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
>
> The addition was:
>
> /* use _snprintf and _vsnprintf */
> #define HAVE_DECL_SNPRINTF 1
> #define snprintf _snprintf
> #define HAVE_DECL_VSNPRINTF 1
> #define vsnprintf _vsnprintf
>
> Now, I think the problem is that with those defines, we will
> not use our port/snprintf.c, meaning the %$ escapes for
> language translation will not work for those builds. I
> realize the backend is the most important for messages, but
> libpq and psql also have message translation.
AFAIK we don't support NLS builds with MSVC anyway. (Check
pg_config.h.win32, it has no #define NLS). So I don't think this is an
issue.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Saito | 2005-12-09 12:12:55 | Re: CVS of 8.1.x MS-VC6 probrem. |
| Previous Message | Dmitry Karasik | 2005-12-09 11:17:06 | Re: implement prepared queries in plperl |