From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Dead encoding conversion functions |
Date: | 2019-05-29 19:10:55 |
Message-ID: | 6B6F5079-A933-42F8-943D-E9A1EF56B47A@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 29 May 2019, at 15:03, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Pursuant to today's discussion at PGCon about code coverage, I went
> nosing into some of the particularly under-covered subdirectories
> in our tree,
On a similar, but much less important/interesting note. I fat-fingered when
compiling isolationtester on the plane over here and happened to compile
src/test/examples, and in there testlo.c and testlo64.c has two dead functions
for which the callsites have been commented out since the Postgres95 import
(and now cause a warning). Is there any (historic?) reason to keep that code?
It also seems kind of broken as it doesn’t really handle the open() call
failure very well.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-05-29 19:20:10 | Re: Pinned files at Windows |
Previous Message | Tom Lane | 2019-05-29 19:03:13 | Dead encoding conversion functions |