| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Selena Deckelmann <selena(at)endpoint(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail |
| Date: | 2009-03-09 01:14:26 |
| Message-ID: | 6830.1236561266@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Not that this has anything to do with the patch at hand, but I remember
> thinking about this sort of error message in the past. Would it be
> appropriate to move the file name and line number to an errcontext()
> field?
I think the message is fine as is. If you moved that information then
you'd have nothing left in the base message but "syntax error", which
is useless.
> I know somebody is going to say "but errcontext is not shown when
> verbosity is set to terse", to which I say that we should fix that too.
No, because the whole point of terse is to be terse. Adding context
to the output would just create a demand for "super terse" mode.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-03-09 01:19:20 | Re: small parallel restore optimization |
| Previous Message | Andrew Dunstan | 2009-03-09 00:45:43 | Re: small parallel restore optimization |