Re: add_missing_from breaks existing views

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: andrew(at)supernews(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: add_missing_from breaks existing views
Date: 2005-10-26 15:41:56
Message-ID: 6691.1130341316@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Should we allow CREATE VIEW to run with "add_missing_from = true" until
> we fix CREATE VIEW to handle this cleanly?

No. Not only is that horridly ugly, it doesn't fix the problem, because
CREATE VIEW is just one case (see also CREATE RULE). If we were to
defeat add_missing_from for both, there wouldn't be much left of it at
all. Going back to default-true would be far cleaner.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-10-26 15:48:19 Re: problem with custom Gist for custom type
Previous Message Andrew Dunstan 2005-10-26 15:37:02 Re: Determining random_page_cost value