Re: [PATCH] Addition of JetBrains project directory to .gitignore

From: David Nedrow <dnedrow(at)me(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Addition of JetBrains project directory to .gitignore
Date: 2019-12-03 19:33:14
Message-ID: 65FF2F2B-FE16-4265-A3FF-42747FA1BE75@me.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Got it, and that makes sense.

I hereby withdraw this patch. ;)

- David

> On Dec 3, 2019, at 10:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>>> On 3 Dec 2019, at 15:47, David Nedrow <dnedrow(at)me(dot)com> wrote:
>>> This patch simply adds “.idea/“ to the list of global excludes across all subdirectories. This directory is created when a JetBrains IDE is used to open a project. In my specific case, Clion is creating the project directory.
>>>
>>> The ONLY change in the patch is the “.idea/“ addition to .gitignore.
>
>> -1. This seems like something better suited in a local gitignore for those who
>> use Jetbrains products. See the documentation for ~/.gitignore_global.
>
> Yeah, we already have a policy that we won't add entries for, say,
> editor backup files. This seems like the same thing. It's stuff
> generated by a tool you use, and you'd need it for any project
> you work on, so a personal ~/.gitexclude seems like the answer.
>
> (Roughly speaking, I think the project policy is/should be that only
> junk files created by application of build rules in our Makefiles
> should be excluded by our own .gitexclude files.)
>
> As a point of reference, I have
>
> $ cat ~/.gitexclude
> *~
> *.orig
>
> to suppress emacs backup files and patch backup files respectively.
> Somebody who prefers another editor would have no use for *~.
>
> regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-12-03 19:58:12 Re: BUG #16079: Question Regarding the BUG #16064
Previous Message Daniel Gustafsson 2019-12-03 17:37:48 Setting min/max TLS protocol in clientside libpq