Re: Suppressing occasional failures in copy2 regression test

From: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Suppressing occasional failures in copy2 regression test
Date: 2009-06-21 21:46:05
Message-ID: 65937bea0906211446q2a15d992uf7e8833a643a652b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 21, 2009 at 11:37 PM, David Fetter <david(at)fetter(dot)org> wrote:

> On Sun, Jun 21, 2009 at 10:36:04PM +0530, Gurjeet Singh wrote:
> > On Sat, Jun 20, 2009 at 2:06 AM, Alvaro Herrera
> > <alvherre(at)commandprompt(dot)com>wrote:
> >
> > > About the comment in chomp: did you try to use different values of $/?
> > >
> > >
> > Well, now that I have tried it, yes, setting $/ to '\r\n' does give me
> what
> > I expected. Both expected and result files should have the same kind of
> line
> > endings though.
>
> Why would \r\n be in our code base anyhow?

I am not implying or expecting that we have \r\n in our test suite.

Its just that maybe my mail client introduced \r\n while downloading the old
attachments, or probably my quite capable Notepad++ converted these files
from \n to \r\n! I am not too sure. But it sure cost me a few cycles to
realize that the files I copied from my Windows host to my Fedora VM were
just not the thing perl would like.

Best regards,
--
Lets call it Postgres

EnterpriseDB http://www.enterprisedb.com

gurjeet[(dot)singh](at)EnterpriseDB(dot)com
singh(dot)gurjeet(at){ gmail | hotmail | indiatimes | yahoo }.com
Mail sent from my BlackLaptop device

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2009-06-22 00:07:54 Missing Docs for MOVE direction?
Previous Message Marc G. Fournier 2009-06-21 21:17:06 Re: rc tarball built with older flex version?