Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vladimir Rusinov <vrusinov(at)google(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date: 2017-01-13 15:00:19
Message-ID: 652848c1-a53e-4aa5-9af6-bc3d4258ad0d@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/12/17 2:22 PM, Stephen Frost wrote:
> The point I was making above is that the only reason to not make such
> changes is if they really are entirely arbitrary, but I don't think
> we'd even be having this discussion if that was the case or that we'd
> be split about the question. We already moved forward with the real
> change here- pg_xlog -> pg_wal, it really astounds me that we're having
> to argue about what is primairly just clean-up from that change, at
> least in my view.

I don't agree with the reasoning. The change of the directory name was
because some people erroneously delete the directory. There is little
to no risk that people accidentally delete built-in functions. It was
not agreed that because we rename the directory that all other uses of
"xlog" have to be removed as well. All those subsequent changes need to
stand on their own.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-01-13 15:07:28 Re: pg_upgrade vs. pg_ctl stop -m fast
Previous Message Peter Eisentraut 2017-01-13 14:56:23 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal