Re: Segmentation fault using digest from pg_crypto

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Segmentation fault using digest from pg_crypto
Date: 2007-11-10 00:38:08
Message-ID: 6519.1194655088@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> If you don't re-run a contrib module's sql script then you don't get any
>> new functions that may have been added to the module. So I think the
>> real issue here is that we ought to deprecate the idea of skipping that
>> step, period.

> The good news is that the scripts have CREATE OR REPLACE function so it
> would clean up everything to match the library you just installed.

Hmm ... now that you mention it: some of them do, some of them don't.
And some of them wrap the whole script in BEGIN/COMMIT, which means that
a conflict against existing definitions would prevent any new
definitions from being added.

Seems like maybe we need an explicit project policy that contrib scripts
should be able to overwrite an existing older installation properly;
maybe with some error reports, but not failing outright.

If so, someone will have to do the legwork of really making that happen
... any volunteers?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-11-10 00:53:32 Re: plpgsql: another new reserved word
Previous Message Gevik Babakhani 2007-11-10 00:37:01 Need for advice and direction (again)