Re: pg_dump losing index column collations for unique and primary keys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexey Bashtanov <bashtanov(at)imap(dot)cc>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: pg_dump losing index column collations for unique and primary keys
Date: 2019-12-03 18:24:38
Message-ID: 6484.1575397478@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> In short, I'd say the bug here is not pg_dump's fault at all,
> but failure to insist on collation match in ADD PRIMARY KEY
> USING INDEX.

Concretely, I think we should do the attached.

I'm not quite sure whether we should back-patch this, though.
It's been wrong since we added collations, but the main impact
of a back-patch might be to break cases that were working more
or less okay for people.

A compromise idea is to back-patch only into v12, where the issue
became quite a lot more important due to nondeterministic
collations.

Thoughts?

regards, tom lane

Attachment Content-Type Size
disallow-collation-mismatch-in-ADD-USING-INDEX.patch text/x-diff 3.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alexey Bashtanov 2019-12-03 19:30:49 Re: pg_dump losing index column collations for unique and primary keys
Previous Message Mahendra Singh 2019-12-03 18:22:39 Re: BUG #16145: Not able to terminate active session