ossp-uuid Contrib Patch

From: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
To: Hackers Pg <pgsql-hackers(at)postgresql(dot)org>
Subject: ossp-uuid Contrib Patch
Date: 2012-09-10 22:14:28
Message-ID: 62FDD311-1AFC-4296-95D8-5751D1407B71@justatheory.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hackers,

I ran into an issue building 9.2 with the OSSP UUID module today. A bit of Googling and I found that the MacPorts guys ran into the same issue a few weeks ago. Their discussion:

https://trac.macports.org/ticket/35153

And the fix:

https://trac.macports.org/browser/trunk/dports/databases/postgresql91/files/postgresql-uuid-ossp.patch?rev=96142

So should we do this in core, too?

Oh, I see Tom already commented on it here:

http://archives.postgresql.org/pgsql-general/2012-07/msg00656.php

I had installed 9.2rc1 a few weeks ago, but since then I upgraded to Mountain Lion. I suspect that is what mucked up the unistd.h ordering issue.

The patch:

diff --git a/contrib/uuid-ossp/uuid-ossp.c b/contrib/uuid-ossp/uuid-ossp.c
index d4fc62b..62b28ca 100644
--- a/contrib/uuid-ossp/uuid-ossp.c
+++ b/contrib/uuid-ossp/uuid-ossp.c
@@ -9,6 +9,7 @@
*-------------------------------------------------------------------------
*/

+#define _XOPEN_SOURCE
#include "postgres.h"
#include "fmgr.h"
#include "utils/builtins.h"

Best,

David

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-09-10 23:16:57 Re: ossp-uuid Contrib Patch
Previous Message Daniel Farina 2012-09-10 21:02:28 Re: Proof of concept: standalone backend with full FE/BE protocol