Re: FDW table hints

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Susanne Ebrecht <susanne(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FDW table hints
Date: 2011-05-05 17:22:18
Message-ID: 6268.1304616138@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Since I brought it up - a patch along this line?

Please don't capitalize "foreign table" there.

Also, I think an "else" before the other ereport would make the code
clearer, even though it's not strictly necessary.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-05-05 17:26:09 Re: FDW table hints
Previous Message Andrew Dunstan 2011-05-05 17:19:29 Re: VARIANT / ANYTYPE datatype