From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Thom Brown <thombrown(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Subject: | Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |
Date: | 2010-01-24 13:37:13 |
Message-ID: | 603c8f071001240537v17bcfae8wa89a2c920b4ff971@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jan 24, 2010 at 8:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Jan 23, 2010 at 10:48 PM, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>> (2010/01/24 12:29), Robert Haas wrote:
>>> I don't think this is ready for committer, becauseTom previously
>>> objected to the approach taken by this patch here, and no one has
>>> answered his objections:
>>>
>>> http://archives.postgresql.org/pgsql-hackers/2010-01/msg00144.php
>>>
>>> I think someone needs to figure out what the worst-case scenario for
>>> this is performance-wise and submit a reproducible test case with
>>> benchmark results. In the meantime, I'm going to set this to Waiting
>>> on Author.
>>
>> Basically, I don't think it is not a performance focused command,
>> because we may be able to assume ALTER TABLE RENAME TO is not much
>> frequent operations.
>
> I agree - the requirements here are much looser than for, say, SELECT
> or UPDATE. But it still has to not suck.
>
> I think the problem case here might be something like this... create
> ten tables A1 through A10. Now create 10 more tables B1 through B10
> each of which inherits from all of A1 through A10. Now create 10 more
> tables C1 through C10 that inherit from B1 through B10. Now create
> 1000 tables D1 through D1000 that inherit from C1 through C10. Now
> drop a column from A1.
Er... rename a column from A1, not drop.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Meskes | 2010-01-24 14:23:24 | Re: ECPG patch 4.1, out-of-scope cursor support in native mode |
Previous Message | Robert Haas | 2010-01-24 13:36:38 | Re: [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns |