From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Add hstore_to_json() |
Date: | 2009-12-16 23:29:48 |
Message-ID: | 603c8f070912161529s577e4235s8ea44427e5c00b20@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 16, 2009 at 5:58 PM, David E. Wheeler <david(at)kineticode(dot)com> wrote:
> On Dec 16, 2009, at 2:45 PM, Robert Haas wrote:
>
>> I like it. The regression tests you've added seem to cover a lot of
>> cases that aren't really different without covering some that are
>> probably worth trying, like multiple key/value pairs. Also, the
>> comment in the function you've added looks like a cut-and-paste from
>> somewhere else, which might not be the best way to document. With
>> regard to the underlying issue, why can't we just use a StringInfo and
>> forget about it?
>
> Dunno. I just duped hstore_out(). I agree there should be more edge cases.
>
>> Also, your indentation is not entirely consistent. If this gets
>> consensus, that will have to be fixed before it can be committed, so
>> it would be nice if you could do that rather than leaving it for the
>> eventual committer.
>
> The indentation is also largely copied; wouldn't pg_indent fix it?
Yeah, eventually, but that's not really a great way of dealing with it.
http://archives.postgresql.org/pgsql-hackers/2009-12/msg01208.php
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-12-16 23:33:43 | Re: determine snapshot after obtaining locks for first statement |
Previous Message | Kevin Grittner | 2009-12-16 23:26:40 | Re: determine snapshot after obtaining locks for first statement |