From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: bug: json format and auto_explain |
Date: | 2009-12-07 16:11:32 |
Message-ID: | 603c8f070912070811g6758eb7fideb3ae40a23b82b@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 7, 2009 at 10:42 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Tom Lane wrote:
>> Euler Taveira de Oliveira <euler(at)timbira(dot)com> writes:
>> > While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
>> > provide a fix right now but if someone can take it I will appreciate. It seems
>> > ExplainJSONLineEnding() doesn't expect es->grouping_stack list as a null pointer.
>>
>> Looks like auto_explain is under the illusion that it need not call
>> ExplainBeginOutput/ExplainEndOutput.
>
> Fortunately the author of auto_explain can now commit the fix by himself ...
> Kudos, BTW :-)
I just tested and this has been broken since it was committed (by
Tom). However, I believe I did test it on the last version of the
patch that I submitted, and I think it worked then. So we have lots
of choices for who should fix this:
- me, since it's my feature
- Tom, since it appears that he broke it
- Itagaki-san, since he's the auto_explain maintainer
:-)
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Filip Rembiałkowski | 2009-12-07 16:12:48 | strange segfault with 8.3.8 |
Previous Message | Alvaro Herrera | 2009-12-07 16:09:59 | Re: Adding support for SE-Linux security |