Re: Review of "SQLDA support for ECPG"

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: Review of "SQLDA support for ECPG"
Date: 2009-10-08 10:44:45
Message-ID: 603c8f070910080344k14b0e6bdybfc99f29e9287727@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 8, 2009 at 6:22 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
> Noah Misch írta:
>> I will report on the sqlda patch in more detail on
>> 2009-10-10.
>
> I am attaching a new one, please review this. Changes:
> - set sqllen, sqlind, sqlilen and sqlitype per-field properties
> - SQLINT8 and SQLSERIAL8 are ECPGt_long on 64-bit, not ECPGt_long_long
>
>>   The one concern that's clear now is a lack of documentation update.
>>
>
> That will come in a separate patch.

What's the point of that? It can't be applied without documentation,
and it just makes life more complicated to have two separate patch
files floating around.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-10-08 10:52:41 Re: Writeable CTEs and side effects
Previous Message Robert Haas 2009-10-08 10:43:30 Re: COPY enhancements