From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Write Ahead Logging for Hash Indexes |
Date: | 2016-09-13 18:34:36 |
Message-ID: | 5f8b4681-1229-92f4-4315-57d780d9c128@redhat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 09/13/2016 07:41 AM, Amit Kapila wrote:
>> README:
>> +in_complete split flag. The reader algorithm works correctly, as it will
>> scan
>>
>> What flag ?
>>
>
> in-complete-split flag which indicates that split has to be finished
> for that particular bucket. The value of these flags are
> LH_BUCKET_NEW_PAGE_SPLIT and LH_BUCKET_OLD_PAGE_SPLIT for new and old
> bucket respectively. It is set in hasho_flag in special area of page.
> I have slightly expanded the definition in README, but not sure if it
> is good idea to mention flags defined in hash.h. Let me know, if still
> it is unclear or you want some thing additional to be added in README.
>
I think it is better now.
>> hashxlog.c:
>>
>> hash_xlog_move_page_contents
>> hash_xlog_squeeze_page
>>
>> Both have "bukcetbuf" (-> "bucketbuf"), and
>>
>> + if (BufferIsValid(bukcetbuf));
>>
>> ->
>>
>> + if (BufferIsValid(bucketbuf))
>>
>> and indent following line:
>>
>> LockBufferForCleanup(bukcetbuf);
>>
>> hash_xlog_delete
>>
>> has the "if" issue too.
>>
>
> Fixed all the above cosmetic issues.
>
I meant there is an extra ';' on the "if" statements:
+ if (BufferIsValid(bukcetbuf)); <--
in hash_xlog_move_page_contents, hash_xlog_squeeze_page and
hash_xlog_delete.
Best regards,
Jesper
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-13 18:47:08 | Re: kqueue |
Previous Message | Andres Freund | 2016-09-13 18:23:06 | Re: kqueue |