Re: pgsql: Change InitToastSnapshot to a macro.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Change InitToastSnapshot to a macro.
Date: 2016-08-05 19:19:59
Message-ID: 57A4E6DF.8070209@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 08/05/2016 12:04 PM, Robert Haas wrote:
> Change InitToastSnapshot to a macro.
>
> tqual.h is included in some front-end compiles, and a static inline
> breaks on buildfarm member castoroides. Since the macro is never
> referenced, it should dodge that problem, although this doesn't
> seem like the cleanest way of hiding things from front-end compiles.
>
> Report and review by Tom Lane; patch by me.

Appears to have caused some buildfarm failures on the decoding tests.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-08-05 20:09:15 pgsql: Make array_to_tsvector() sort and de-duplicate the given strings
Previous Message Tom Lane 2016-08-05 19:14:33 pgsql: Re-pgindent tsvector_op.c.