Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Date: 2016-04-25 02:42:29
Message-ID: 571D8415.3050109@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 04/21/2016 08:18 PM, Tom Lane wrote:
> Hm. This seems to prove that we're not getting exactly 1.0 from
> (asin(x) / asin_0_5) with x = 0.5, but I'm having a hard time guessing
> why that might be so when all the other cases work.
>
> Could you send along the assembler code generated by the compiler (-S
> output) for float.c? Maybe that would shed some light. Probably the
> -O0 version would be easier to read.

Attached is a smaller test program that prints 29.9999999999999964 (same
as failing test result) as well as its assembler code.

Attachment Content-Type Size
test.c text/x-csrc 232 bytes
test.s text/plain 1.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-25 02:56:32 Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Previous Message Peter Eisentraut 2016-04-25 00:59:41 pgsql: Update GETTEXT_FILES after config and controldata refactoring

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-04-25 02:44:31 Re: Rename max_parallel_degree?
Previous Message Stephen Frost 2016-04-25 01:27:33 Re: Add jsonb_compact(...) for whitespace-free jsonb to text