| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VS 2015 support in src/tools/msvc |
| Date: | 2016-04-23 20:11:00 |
| Message-ID: | 571BD6D4.9@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/22/2016 01:21 AM, Michael Paquier wrote:
>>> 5. It also complains about us casting a pid_t to a HANDLE in
>>> pg_basebackup.c. Not sure what to do about that.
>> The thing that's being cast is not a PID, but a HANDLE to a process. pid_t is a typedef for int (in port/win32.h), therefore is always 32 bits, while HANDLE is actually void*. However, Microsoft guarantees that kernel32 HANDLEs (this includes those to threads and processes) fit into 32 bits on AMD64.
>>
>> Source: https://msdn.microsoft.com/en-us/library/windows/desktop/ee872017(v=vs.85).aspx, third bullet point.
>>
>> So we can simply silence the warning by casting explicitly.
> Yes, when casting things this way I think that a comment would be fine
> in the code. We could do that as separate patches actually.
We are already casting the pid_t to HANDLE and still getting a warning.
Apparently we need to do something on win64 like
(HANDLE) ((int64) bgchild)
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2016-04-23 21:30:45 | Re: VS 2015 support in src/tools/msvc |
| Previous Message | Peter Eisentraut | 2016-04-23 18:55:21 | Re: pgbench doc typos |