Re: Typos/Questions in bloom documentation

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typos/Questions in bloom documentation
Date: 2016-04-21 01:57:35
Message-ID: 5718338F.6000308@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016/04/21 6:51, David G. Johnston wrote:
> http://www.postgresql.org/docs/devel/static/bloom.html
>
> F.4.3 Examples
>
> Claims that the signature length is 80 bits - shouldn't it be 8?

In F.4.1. Introduction:

... The user can specify signature length (in uint16, default is 5)

So, it seems right to me.

> Also, is it OK to link to wikipedia in our documentation? (the link to
> bloom filter in the second paragraph)

grep wikipedia doc reveals at least some hits:

doc/src/sgml/release.sgml:26
doc/src/sgml/isn.sgml:361
doc/src/sgml/isn.sgml:367
doc/src/sgml/isn.sgml:369
doc/src/sgml/textsearch.sgml:2774
doc/src/sgml/bloom.sgml:21
doc/src/sgml/monitoring.sgml:2728
doc/src/sgml/pgcrypto.sgml:1289
doc/src/sgml/pgcrypto.sgml:1351

And then some:

doc/src/sgml/acronyms.sgml:16
doc/src/sgml/acronyms.sgml:26
doc/src/sgml/acronyms.sgml:35
doc/src/sgml/acronyms.sgml:54
...

> F.4.4 "Opclass interface"
>
> The "I" should be capitalized in a proper title
>
> F.4.5 Limitation
>
> Should be plural

Attached is a patch for these fixes.

Thanks,
Amit

Attachment Content-Type Size
bloom-doc-typos.patch text/x-diff 567 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2016-04-21 02:05:38 Re: Declarative partitioning
Previous Message Peter Geoghegan 2016-04-21 01:52:06 Re: Avoid parallel full and right join paths.