| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Description of ForeignPath |
| Date: | 2016-04-20 07:20:43 |
| Message-ID: | 57172DCB.5040700@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/04/18 17:31, Amit Langote wrote:
> Is the following description now outdated:
>
> "ForeignPath represents a potential scan of a foreign table"
>
> Considering that there now exists FdwRoutine.GetForeignJoinPaths() whose
> product is nothing else but a ForeignPath, should it now say (patch attached):
>
> "ForeignPath represents a potential scan of foreign table(s)"
>
> Or something better.
I think it'd be better to match the comment with that for
create_foreignscan_path(). So how about "ForeignPath represents a
potential scan of a foreign table, foreign join, or foreign
upper-relation processing"? I think we would probably need to update
the comment in src/backend/optimizer/README (L358), too.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2016-04-20 07:37:06 | Re: Description of ForeignPath |
| Previous Message | Fujii Masao | 2016-04-20 07:16:40 | Re: FATAL: could not send end-of-streaming message to primary: no COPY in progress |