Re: pg_sequence catalog

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_sequence catalog
Date: 2017-01-03 18:17:32
Message-ID: 56d10bfc-f994-b080-d91a-611ca15537bd@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/03/2017 03:30 PM, Peter Eisentraut wrote:
> On 1/3/17 7:23 AM, Kuntal Ghosh wrote:
>> The regression tests for hot standby check fails since it uses the
>> following statement:
>> -select min_value as sequence_min_value from hsseq;
>> which is no longer supported I guess. It should be modified as following:
>> select min_value as sequence_min_value from pg_sequences where
>> sequencename = 'hsseq';
>>
>> Attached is a patch which reflects the above changes.
>
> Fixed, thanks.
>
> I made a note to self to port this test to the TAP framework.

Hm, doesn't this change the intent of the test case? As I read the test
it seems to make sure that we are allowed to do a read from a sequence
relation on the slave. If so I think it should be changed to something
like the below.

select is_called from hsseq;

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-01-03 18:30:11 Re: Cluster wide option to control symbol case folding
Previous Message Tom Lane 2017-01-03 18:12:00 Re: [HACKERS] pgsql: Update copyright for 2017