Re: Sequence Access Method WIP

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: fabriziomello(at)gmail(dot)com, David Steele <david(at)pgmasters(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sequence Access Method WIP
Date: 2016-03-29 17:26:28
Message-ID: 56FABAC4.9050303@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29/03/16 18:50, Fabrízio de Royes Mello wrote:
>
>
> On Tue, Mar 29, 2016 at 12:25 PM, David Steele <david(at)pgmasters(dot)net
> <mailto:david(at)pgmasters(dot)net>> wrote:
> >
> > Hi Petr,
> >
> > On 3/28/16 3:11 PM, Fabrízio de Royes Mello wrote:
> >
> >> fabrizio(at)bagual:~/pgsql
> >> $ bin/pg_dump > /tmp/fabrizio.sql
> >> pg_dump: [archiver (db)] query failed: ERROR: column "sequence_name"
> >> does not exist
> >> LINE 1: SELECT sequence_name, start_value, increment_by, CASE WHEN i...
> >> ^
> >> pg_dump: [archiver (db)] query was: SELECT sequence_name, start_value,
> >> increment_by, CASE WHEN increment_by > 0 AND max_value =
> >> 9223372036854775807 THEN NULL WHEN increment_by < 0 AND max_value =
> >> -1 THEN NULL ELSE max_value END AS max_value, CASE WHEN
> >> increment_by > 0 AND min_value = 1 THEN NULL WHEN increment_by < 0
> >> AND min_value = -9223372036854775807 THEN NULL ELSE min_value END
> >> AS min_value, cache_value, is_cycled FROM x
> >
> >
> > It looks like a new patch is needed. I've marked this "waiting on
> author".
> >
>

Yeah there were some incompatible commits since my last rebase, fixed,
along with the pg_dump bugs..

>
> But there are other issue in the gapless-seq extension when I ran "make
> check":
>
> 43 CREATE EXTENSION gapless_seq;
> 44 CREATE SEQUENCE test_gapless USING gapless;
> 45 SELECT nextval('test_gapless'::regclass);
> 46 ! ERROR: could not access status of transaction 1275068416
> 47 ! DETAIL: Could not open file "pg_subtrans/4C00": No such file or
> directory.
> 48 BEGIN;
> 49 SELECT nextval('test_gapless'::regclass);
> 50 ! ERROR: could not access status of transaction 1275068416
> 51 ! DETAIL: Could not open file "pg_subtrans/4C00": No such file or
> directory.
> 52 SELECT nextval('test_gapless'::regclass);
> 53 ! ERROR: current transaction is aborted, commands ignored until
> end of transaction block
> 54 SELECT nextval('test_gapless'::regclass);
> 55 ! ERROR: current transaction is aborted, commands ignored until
> end of transaction block
> 56 ROLLBACK;
> 57 SELECT nextval('test_gapless'::regclass);
> 58 ! ERROR: could not access status of transaction 1275068416
> 59 ! DETAIL: Could not open file "pg_subtrans/4C00": No such file or
> directory.
>
>
> And I see the same running manually:
>
> fabrizio=# create extension gapless_seq;
> CREATE EXTENSION
> fabrizio=# create sequence x using gapless;
> CREATE SEQUENCE
> fabrizio=# select nextval('x');
> ERROR: could not access status of transaction 1258291200
> DETAIL: Could not open file "pg_subtrans/4B00": No such file or directory.
>
> Regards,
>

Hmm I am unable to reproduce this. What OS? Any special configure flags
you use?

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0002-gapless-seq-2016-03-29.patch text/x-diff 28.4 KB
0001-seqam-2016-03-29.patch text/x-diff 170.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-03-29 17:28:13 Re: raw output from copy
Previous Message Tom Lane 2016-03-29 17:24:40 Re: Move PinBuffer and UnpinBuffer to atomics