Re: pgsql: Checkpoint sorting and balancing.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Checkpoint sorting and balancing.
Date: 2016-03-11 01:47:10
Message-ID: 56E2239E.1050607@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 3/10/16 8:29 PM, Andres Freund wrote:
> Checkpoint sorting and balancing.

This patch appears to have introduced a change that makes the build
with dtrace fail:

In file included from ../../../../src/include/pg_trace.h:15:0,
from bufmgr.c:42:
bufmgr.c: In function 'BufferSync':
bufmgr.c:1939:59: error: 'num_to_write' undeclared (first use in this function)
TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
^
../../../../src/include/utils/probes.h:93:83: note: in definition of macro 'TRACE_POSTGRESQL_BUFFER_SYNC_DONE'
__dtrace_probe$postgresql$buffer__sync__done$v1$696e74$696e74$696e74(arg0, arg1, arg2); \
^~~~
bufmgr.c:1939:59: note: each undeclared identifier is reported only once for each function it appears in
TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
^
../../../../src/include/utils/probes.h:93:83: note: in definition of macro 'TRACE_POSTGRESQL_BUFFER_SYNC_DONE'
__dtrace_probe$postgresql$buffer__sync__done$v1$696e74$696e74$696e74(arg0, arg1, arg2); \
^~~~

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-03-11 01:51:34 pgsql: Blindly try to fix dtrace enabled builds, broken in 9cd00c45.
Previous Message Joel Jacobson 2016-03-11 01:31:56 Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity.