Re: [HACKERS] Packaging of postgresql-jdbc

From: Álvaro Hernández Tortosa <aht(at)8kdata(dot)com>
To: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
Cc: Pavel Raiskup <praiskup(at)redhat(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org>, Matteo Melli <matteom(at)8kdata(dot)com>, Pavel Kajaba <pkajaba(at)redhat(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, hhorak(at)redhat(dot)com
Subject: Re: [HACKERS] Packaging of postgresql-jdbc
Date: 2016-02-17 17:49:20
Message-ID: 56C4B2A0.9090902@8kdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On 17/02/16 18:43, Vladimir Sitnikov wrote:
> Álvaro> I think running tests is cool for the packaging process,
> but is this needed for packaging? I mean, it's upstream who should run
> them before releasing versions, right? :)
>
> If you pick "upstream build artifact", you know it is tested.
Yeah, that's what I meant :) No need to test it if taken from upstream.

> If you use custom-made-kludge-patched build process, you'd better test
> that new artifact before use.
> It can easily fail in a unexpected way. For instance: not all ${...}
> being replaced, not all the classes present, missing translations,
> etc, etc.

Absolutely. But the two proposed changes here are:

- Remove waffle dependency from pom file (it's obviously not needed in
Fedora). I don't think this requires any testing (if it compiles, of course)

- Replace osgi.enterprise by something else. This something else will be
present in upstream, and hence tests.

:)

Álvaro

--
Álvaro Hernández Tortosa

-----------
8Kdata

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Raiskup 2016-02-17 18:22:29 Re: [HACKERS] Packaging of postgresql-jdbc
Previous Message Daniel Verite 2016-02-17 17:48:21 Re: [patch] Proposal for \crosstabview in psql

Browse pgsql-jdbc by date

  From Date Subject
Next Message Pavel Raiskup 2016-02-17 18:22:29 Re: [HACKERS] Packaging of postgresql-jdbc
Previous Message Vladimir Sitnikov 2016-02-17 17:43:50 Re: [HACKERS] Packaging of postgresql-jdbc