Re: 9.4 failure on skink in _bt_newroot/XLogCheckBuffer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 9.4 failure on skink in _bt_newroot/XLogCheckBuffer
Date: 2016-05-21 21:18:14
Message-ID: 56703.1463865494@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> The valgrind animal just reported a large object related failure on 9.4:

The proximate cause seems to be that _bt_newroot isn't bothering to
fill the buffer_std field here:

/* Make a full-page image of the left child if needed */
rdata[2].data = NULL;
rdata[2].len = 0;
rdata[2].buffer = lbuf;
rdata[2].next = NULL;

which is indeed an actual bug, but the only consequence would be poor
compression of the full-page image (if the value chanced to be zero),
so it's not much of a problem.

What remains unclear is how come this only fails once in a blue moon.
Seems like any valgrind run of the regression tests should have caught it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2016-05-21 22:16:06 Re: Parallel safety tagging of extension functions
Previous Message Andres Freund 2016-05-21 20:31:01 9.4 failure on skink in _bt_newroot/XLogCheckBuffer