Re: [PROPOSAL] TAP test example

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PROPOSAL] TAP test example
Date: 2015-11-19 15:39:41
Message-ID: 564DED3D.7000004@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/19/15 8:42 AM, Nikolay Shaplov wrote:
> +sub psql_ok
> +{
> + my $db = shift;
> + my $sql = shift;
> + my $comment = shift;

Isn't the preferred method of parameter assignment to use @_?

Also, I'd think one of the examples should use DBI, since presumably one
of the big benefits to tap is not dealing with raw psql output...
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2015-11-19 15:47:01 Re: [PROPOSAL] TAP test example
Previous Message Tom Lane 2015-11-19 15:21:14 Re: proposal: LISTEN *