Re: Cross-check recent documentation changes

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Robins <robins(at)pobox(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cross-check recent documentation changes
Date: 2015-10-29 10:05:03
Message-ID: 5631EF4F.6090305@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Robins,

On 2015/10/29 10:40, Robins wrote:
> Hi,
>
> Was reviewing recent commits, and it seems the following commit adds an
> extra line to some comments. Just wanted to cross-check if that was
> intentional.
>
> Commit: http://goo.gl/zxA00l
> Pre-Commit: http://goo.gl/2DpLxi
> Post-Commit: http://goo.gl/eKcNm3

You can see a minor change in the "extra line" - member vs. members in the
first and second version, respectively, of essentially the same message.
errmsg_plural() function determines whether to output the singular version
or the plural based on numeric value of the first variadic argument passed
to it. For example, if "%d" in the formatted output turns out be 1, "... 1
multixact members ..." in the output message sounds awkward. So does "...
10 multixact member". Hence the committed change.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-10-29 10:12:39 Re: [ADMIN] Replication slots and isolation levels
Previous Message Vladimir Borodin 2015-10-29 08:42:57 Re: [ADMIN] Replication slots and isolation levels