| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, "PostgreSQL-development (pgsql-hackers(at)postgresql(dot)org)" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PROPOSAL] VACUUM Progress Checker. |
| Date: | 2015-10-02 07:14:42 |
| Message-ID: | 560E2EE2.40200@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/02 15:38, Fujii Masao wrote:
>
> + uint32 progress_param[N_PROGRESS_PARAM];
>
> Why did you use an array to store the progress information of VACUUM?
> I think that it's better to use separate specific variables for them for
> better code readability, for example, variables scanned_pages,
> heap_total_pages, etc.
>
> + double progress_param_float[N_PROGRESS_PARAM];
>
> Currently only progress_param_float[0] is used. So there is no need to
> use an array here.
I think this kind of design may have come from the ideas expressed here
(especially the last paragraph):
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2015-10-02 08:00:41 | Confusing remark about UPSERT in fdwhandler.sgml |
| Previous Message | Fujii Masao | 2015-10-02 06:38:42 | Re: [PROPOSAL] VACUUM Progress Checker. |