From: | Euler Taveira <euler(at)timbira(dot)com(dot)br> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pltcl: sentence improvement |
Date: | 2015-09-16 15:16:37 |
Message-ID: | 55F987D5.7020408@timbira.com.br |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 16-09-2015 10:57, Tom Lane wrote:
> Euler Taveira <euler(at)timbira(dot)com(dot)br> writes:
>> This simple patch improves a sentence. Spotted while working on translation.
>
> I concur that spelling out "#" as "number" is an improvement, but I'm
> curious which backend error you think this matches?
>
It is sort of...
utils/adt/json.c
2088 ereport(ERROR,
2089 (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
2090 errmsg("argument list must have even number of
elements"),
2091 errhint("The arguments of json_build_object() must
consist of alternating keys and values.")));
replication/logical/logicalfuncs.c
361 ereport(ERROR,
362 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
363 errmsg("array must have even number of
elements")));
> Also, if we're going to change this message at all, I'm inclined to
> rewrite it completely, because it doesn't really follow the style
> guidelines. How about "trigger's return list must have even number of
> elements"?
>
Works for me.
--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2015-09-16 15:31:48 | BUFFER_LOCK_* synonyms |
Previous Message | Dean Rasheed | 2015-09-16 15:14:39 | Re: Inaccurate results from numeric ln(), log(), exp() and pow() |