Re: Inconsistent style in pgbench's error messages

On 07/05/2015 04:46 PM, Tom Lane wrote:
> I made a pass over pgbench's error messages to try to make them meet
> project style guidelines. There was one rather large bit of inconsistency
> that I didn't try to fix, though: something like half of the messages
> prepend "pgbench: " to the front, but the other half don't. Worse yet,
> some of the other half prepend other things like metacommand names, which
> seems quite confusing if you're expecting the former convention.
>
> I'd like to see that become consistent, but I am not sure which way we
> want to jump. Personally I think "pgbench: " adds very little and so
> I'd rather get rid of it, but I'm sure others feel differently.

I would agree that adding pgbench is useless. You know if you ware
running pgbench. Heck if you don't know, the logs become rather obvious
regardless.

JD
>

--
Command Prompt, Inc. - http://www.commandprompt.com/ 503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Announcing "I'm offended" is basically telling the world you can't
control your own emotions, so everyone else should do it for you.