Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Subject: Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Date: 2015-04-24 07:31:53
Message-ID: 5539F169.1060603@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/24/2015 02:52 AM, Peter Geoghegan wrote:
> I found a bug that seems to be down to commit
> e3144183562d08e347f832f0b29daefe8bac617b on Github:
>
> """
> commit e3144183562d08e347f832f0b29daefe8bac617b
> Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
> Date: Thu Apr 23 18:38:11 2015 +0300
>
> Minor cleanup of check_exclusion_or_unique_constraint.
>
> To improve readability.
>
> """
>
> At least, that's what a "git bisect" session showed.

Ok, I see now that I totally screwed up the conditions on "waitMode" in
that commit. I just pushed a fix to your github repository.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-04-24 07:44:33 Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Previous Message Heikki Linnakangas 2015-04-24 06:36:29 Re: Moving ExecInsertIndexTuples and friends to new file