| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: TABLESAMPLE patch |
| Date: | 2015-04-01 23:38:09 |
| Message-ID: | 551C8161.6010203@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/04/15 18:38, Robert Haas wrote:
> On Wed, Apr 1, 2015 at 12:15 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>> REPEATABLE is mandated by standard. I did try for quite some time to make it
>> unreserved but was not successful (I can only make it unreserved if I make
>> it mandatory but that's not a solution). I haven't been in fact even able to
>> find out what it actually conflicts with...
>
> Yeah, that can be hard to figure out. Did you run bison with -v and
> poke around in gram.output?
>
Oh, no I didn't (I didn't know gram.output will be generated). This
helped quite a bit. Thanks.
I now found the reason, it's conflicting with alias but that's my
mistake - alias should be before TABLESAMPLE clause as per standard and
I put it after in parser. Now that I put it at correct place REPEATABLE
can be unreserved keyword. This change requires making TABLESAMPLE a
"type_func_name_keyword" but that's probably not really an issue as
TABLESAMPLE is reserved keyword per standard.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-04-02 00:10:44 | Re: The return value of allocate_recordbuf() |
| Previous Message | David Fetter | 2015-04-01 23:32:15 | Re: POLA violation with \c service= |