From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: searching in array function - array_position |
Date: | 2015-03-10 21:18:12 |
Message-ID: | 54FF5F94.4070806@BlueTreble.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/10/15 10:53 AM, Jim Nasby wrote:
> On 3/10/15 9:30 AM, Robert Haas wrote:
>> On Sat, Mar 7, 2015 at 1:06 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com>
>> wrote:
>>> You still duplicate the type cache code, but many other array
>>> functions do
>>> that too so I will not hold that against you. (Maybe somebody should
>>> write
>>> separate patch that would put all that duplicate code into common
>>> function?)
>>>
>>> I think this patch is ready for committer so I am going to mark it as
>>> such.
>>
>> The documentation in this patch needs some improvements to the
>> English. Can anyone help with that?
>
> I'll take a look at it.
>
>> The documentation should discuss what happens if the array is
>> multi-dimensional.
This is the wording I have to describe what happens with a
multi-dimensional array. I'm not thrilled with it; anyone have better ideas?
Note: multi-dimensional arrays are squashed to one dimension before
searching.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2015-03-10 21:53:11 | Re: proposal: searching in array function - array_position |
Previous Message | Stephen Frost | 2015-03-10 21:13:00 | Re: get_object_address support for additional object types |