| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Patch: raise default for max_wal_segments to 1GB |
| Date: | 2015-03-03 18:21:32 |
| Message-ID: | 54F5FBAC.4000600@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2015 10:15 AM, Josh Berkus wrote:
> On 03/02/2015 11:25 PM, Heikki Linnakangas wrote:
>> I propose that we remove the comment from max_wal_size, and also remove
>> the "in milliseconds" from wal_receiver_timeout and
>> autovacuum_vacuum_cost_delay.
>
> +1
>
Actually, let's be consistent about this. It makes no sense to remove
unit comments from some settings which accept ms but not others.
Do we want to remove unit comments from all settings which accept
"MB,GB" or "ms,s,min"? There's more than a few. I'd be in favor of
this, but seems like (a) it should be universal, and (b) its own patch.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2015-03-03 18:28:58 | Re: Comparing primary/HS standby in tests |
| Previous Message | Josh Berkus | 2015-03-03 18:15:32 | Re: Patch: raise default for max_wal_segments to 1GB |