Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
Subject: Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)
Date: 2015-01-09 23:18:54
Message-ID: 54B061DE.5070707@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/6/15, 5:43 PM, Kouhei Kaigai wrote:
>>> scan_relid != InvalidOid
>>> > >
>> >
>> >Ideally, they should be OidIsValid(scan_relid)
>> >
> Scan.scanrelid is an index of range-tables list, not an object-id.
> So, InvalidOid or OidIsValid() are not a good choice.

I think the name needs to change then; scan_relid certainly looks like the OID of a relation.

scan_index?
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2015-01-09 23:32:40 libpq 9.4 requires /etc/passwd?
Previous Message Stephen Frost 2015-01-09 21:40:41 Re: INSERT ... ON CONFLICT UPDATE and RLS