Re: What in the world is happening on spoonbill?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: What in the world is happening on spoonbill?
Date: 2008-05-17 19:52:07
Message-ID: 5494.1211053927@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> BTW, this exposes a pretty nasty omission in pg_regress: it fails to
> say anything about a nonzero exit code from a psql child process
> that's running a test. Seems like wait_for_tests() ought to complain
> about that. Any objections?

So I coded this up, and fortunately thought to try it with ecpg's tests
before committing:

test preproc/define ... ok
test preproc/init ... ok
test preproc/type ... ok
test preproc/variable ... ok
test preproc/whenever ... FAILED: test process exited with exit code 1
test sql/array ... ok
test sql/binary ... ok
test sql/code100 ... ok
test sql/copystdout ... ok

Apparently the exit(1) is intentional in that test.

We could possibly extend the syntax of regression schedule files to have
a way to say what's the expected exit status, but that seems like more
work than it's worth. Would it be all right to just remove the test of
"on error stop" mode?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolas Barbier 2008-05-17 20:02:28 Re: Would like to sponsor implementation of MATERIALIZED VIEWS
Previous Message Josh Berkus 2008-05-17 19:13:24 Re: [rfc,patch] PL/Proxy in core