Re: UW 713UP3 patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Larry Rosenman <ler(at)lerctr(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: UW 713UP3 patch
Date: 2003-11-02 23:17:26
Message-ID: 5479.1067815046@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Larry Rosenman <ler(at)lerctr(dot)org> writes:
> +# version check for the 7.1.3UP3 compiler (version 401200310):
> +cat >conftest.c <<__EOF__
> +int main(int argc, char **argv)
> +#if __SCO_VERSION__ >=3D 401200310
> +#error good compiler
> +#else
> +#error bad compiler
> +#endif
> +__EOF__
> + $CC conftest.c 2>conftest.err 1>&2
> + grep -q good conftest.err
> + if test $? =3D 0; then
> + CFLAGS=3D"-O -Kinline"
> + else
> + CFLAGS=3D"-O -Kinline,no_host"
> + fi

Couldn't this be simplified to

+cat >conftest.c <<__EOF__
+int main(int argc, char **argv)
+{
+#if __SCO_VERSION__ < 401200310
+#error bad compiler
+#endif
+}
+__EOF__
+ $CC conftest.c >/dev/null 2>&1
+ if test $? = 0; then
+ CFLAGS="-O -Kinline"
+ else
+ CFLAGS="-O -Kinline,no_host"
+ fi

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2003-11-02 23:23:58 Re: UW 713UP3 patch
Previous Message Larry Rosenman 2003-11-02 22:07:37 Re: UW 713UP3 patch