Re: Preliminary patch for FRONTEND

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Preliminary patch for FRONTEND
Date: 2004-10-01 05:43:24
Message-ID: 5455.1096609404@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The following patch addresses this issue by making libpgport usable
> unchanged by client applications, and makes a special server version for
> the backend.

This raises some alarm bells for me. Why does a "port support" library
need to distinguish whether it is running in frontend or backend?
Certainly the standard Unix library calls that it is purporting to
replace do not care.

Also, the patch does both more and less than I'd expect from your
description. Why are there no changes at all to C code? And how can
you just remove, eg, dirmod.c and exec.c from pg_resetxlog?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-01 06:21:41 Re: Cosmetic changes
Previous Message Neil Conway 2004-10-01 05:19:09 Re: Preliminary patch for FRONTEND