| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Gabriele Bartolini <gabriele(dot)bartolini(at)2ndquadrant(dot)it>, Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RFC] Incremental backup v2: add backup profile to base backup |
| Date: | 2014-10-06 16:24:32 |
| Message-ID: | 5432C240.1020207@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/06/2014 07:00 PM, Gabriele Bartolini wrote:
> Hello,
>
> 2014-10-06 17:51 GMT+02:00 Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it
>> :
>
>> I agree that a full backup does not need to include a profile.
>>
>> I've added the option to require the profile even for a full backup, as
>> it can be useful for backup softwares. We could remove the option and
>> build the profile only during incremental backups, if required. However,
>> I would avoid the needing to scan the whole backup to know the size of
>> the recovered data directory, hence the backup profile.
>
> I really like this approach.
>
> I think we should leave users the ability to ship a profile file even in
> case of full backup (by default disabled).
I don't see the point of making the profile optional. Why burden the
user with that decision? I'm not convinced we need it at all, but if
we're going to have a profile file, it should always be included.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2014-10-06 16:53:20 | pg_receivexlog always handles -d option argument as connstr |
| Previous Message | Robert Haas | 2014-10-06 16:19:44 | Re: [RFC] Incremental backup v2: add backup profile to base backup |