Re: Patch for ALTER DATABASE WITH TABLESPACE

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for ALTER DATABASE WITH TABLESPACE
Date: 2008-11-04 20:12:04
Message-ID: 53E161336762B0E3E7D81AED@imhotep.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

--On Dienstag, November 04, 2008 14:56:44 -0500 Tom Lane
<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

[...]

>
> Not sure what Bernd tried exactly, but it can be done.
>

Cool, i didn't recognize the obvious possibility to add a separate rule for
this. I've just extended the alterdb_opt_item with SET TABLESPACE, which
lead to a shift/reduce.

> I see the point about the parallel to CREATE DATABASE, but on the other
> hand we also have ALTER DATABASE SET for parameters. I suspect people
> are more likely to expect the SET syntax.
>

Yes, that seems logical to me, too. So i think we should go for it.
Guillaume?

--
Thanks

Bernd

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2008-11-04 20:15:15 Re: Patch for ALTER DATABASE WITH TABLESPACE
Previous Message Jonah H. Harris 2008-11-04 20:07:26 [PATCH] Cleanup of PLpgSQL_recfield