| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Antonin Houska <antonin(dot)houska(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
| Subject: | Re: bgworker crashed or not? |
| Date: | 2014-04-24 09:22:13 |
| Message-ID: | 5358D7C5.7060706@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24/04/14 07:39, Craig Ringer wrote:
> On 04/17/2014 08:35 AM, Craig Ringer wrote:
>>
>> As far as I can tell we have a couple of options:
>>
>> - Redefine what the exit codes mean so that exit 0 suppresses
>> auto-restart and exits silently. Probably simplest.
>
> I'm now strongly in favour of this alternative.
>
> I've just noticed that the bgworker control interfaces do not honour
> bgw.bgw_restart_time = BGW_NEVER_RESTART if you exit with status zero.
>
> This means that it's not simply a problem where you can't say "restart
> me if I crash, but not if I exit normally".
>
> You also can't even say "never restart me at all". Because
> "BGW_NEVER_RESTART" seems to really mean "BGW_NO_RESTART_ON_CRASH".
>
Yes this was one of the reasons why I complained also. Maybe it would be
enough to just honor the bgw_restart_time always.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2014-04-24 10:46:20 | Json(b) extension |
| Previous Message | Ian Barwick | 2014-04-24 08:24:01 | Re: Perfomance degradation 9.3 (vs 9.2) for FreeBSD |