Re: Bugfix and new feature for PGXS

On 10/07/2013 08:47 PM, Peter Eisentraut wrote:
> On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote:
>> On 09/03/2013 04:04 AM, Cédric Villemain wrote:
>>>> Simple one, attached.
>>>> I didn't document USE_VPATH, not sure how to explain that clearly.
>>> Just a remember that the doc is written and is waiting to be commited.
>>>
>>> There is also an issue spoted by Christoph with the installdirs prerequisite,
>>> the attached patch fix that.
>>>
>> I applied this one line version of the patch, which seemed more elegant
>> than the later one supplied.
>>
>> I backpatched that and the rest of the VPATH changes for extensiuons to
>> 9.1 where we first provided for extensions, so people can have a
>> reasonably uniform build system for their extensions.
> I suspect this line
>
> submake-libpq: $(libdir)/libpq.so ;
>
> will cause problems on platforms with a different extension (e.g. OS X).
>
> Given that this supposedly small and noninvasive set of changes has
> caused a number of problems already, I suggest we revert this entire
> thing until we have had time to actually test it somewhere other than in
> the the stable branches. As it stands, it is a new feature being
> developed in the stable branches, which is clearly not acceptable.

If you want to revert it then go ahead, but the last statement is simply
incorrect. The code has been sitting in HEAD for several months, and I
committed on the back branches because it was wanted.

cheers

andrew