Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)

From: Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
To: Florian Pflug <fgp(at)phlo(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Brendan Jurd <direvus(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)
Date: 2013-04-03 15:34:34
Message-ID: 515C4C0A.1010500@archidevsys.co.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/04/13 03:02, Florian Pflug wrote:
> On Apr3, 2013, at 15:30 , Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On 04/02/2013 02:46 PM, Florian Pflug wrote:
>>> If we're going to break compatibility, we should IMHO get rid of
>>> non-zero lower bounds all together. My guess is that the number of
>>> affected users wouldn't be much higher than for the proposed patch,
>>> and it'd allow lossless mapping to most language's native array types…
>> That would actually break a HUGE number of users, since the default lower
>> bound is 1. I have seen any number of pieces if code that rely on that.
> Uh, yeah, we should make it 1 then, not 0, then. As long as the bound
> is fixed, conversion to native C/Java/Ruby/Python/... arrays would still
> be lossless.
>
> best regards,
> Florian Pflug
>
>
Zero as the default lower bound is consistent with most languages
(especially the common ones like C, C++, Java, & Python), in fact I
don't remember any language where that is not the case (ignoring SQL) -
and I've written programs in about 20 languages.

Maybe we should adopt the famous compromise of '0.5'? :-)

Cheers,
Gavin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-04-03 15:41:03 Re: Regex with > 32k different chars causes a backend crash
Previous Message Rodrigo Barboza 2013-04-03 15:26:05 c language functions